1. Mar 16, 2023
  2. Mar 15, 2023
    • Sascha Bacardit's avatar
      PEMA-309 Updated code as per codereview requests · cd29f22e
      Sascha Bacardit authored
      Added guard let construct
      Properly intended messages
      Fixed incoherent messages (sometimes no email provider name, sometimes it had it on ouath)
      cd29f22e
    • Sascha Bacardit's avatar
      PEMA-309 further refined code · bc07b5aa
      Sascha Bacardit authored
      After reading the code review the following changes have been added:
      -Made isCloud less exposing to inner data.
      -Added descriptor for LoginProtocol
      -Added guard let to most functions in LoginUtil and those using callbacks from it.
      bc07b5aa
    • Sascha Bacardit's avatar
      PEMA-309 removed class · 7de07fed
      Sascha Bacardit authored
      OIDAuthState should not exist (moved to messagemodel)
      7de07fed
    • Sascha Bacardit's avatar
      PEMA-309 refractored classes · 41fb6bd2
      Sascha Bacardit authored
      After review, most classes had small issues with their formating or location, as such the following has been fixed:
      Added proper tab and formating for them
      Renamed certain classes to keep within expected logic (CamelCase, OIDAuthState+JWT)
      Moved OIDauthState to messagemodel along with most OAuth adjacent classes where it should be.
      Changed OIDAuth signature to remove references to things the class shouldn't know (such as the name of fields inside the JWToken) 
      Refractored OAuth2AccessToken and protocol to fit with being able to give email and name from the JWToken.
      41fb6bd2
    • Sascha Bacardit's avatar
      PEMA-309 · 7c7cc5e4
      Sascha Bacardit authored
      Further cleaned up the classes, added less strange ways to set up things and removed oddities like an initialise function which didn't make much sense, as the protocol doesn't really care how you handle your responses.
      7c7cc5e4
    • Sascha Bacardit's avatar
      PEMA-309 · cac5a4ba
      Sascha Bacardit authored
      Cleaned up code, removed old dead code and added placeholder tests.
      Additionally added comments to the stranger functions (OIDauth extension).
      cac5a4ba
    • Sascha Bacardit's avatar
      PEMA-309 · 760136c5
      Sascha Bacardit authored
      Added temporary test placeholders.
      760136c5
    • Sascha Bacardit's avatar
      PEMA-309 Added LoginLogic, JWT parser class · 5110ab11
      Sascha Bacardit authored
      Added abstraction class for login, it should handle all cases and all internal login logic (saving data, etc...) only returning an error state or a success state.
      
      Adjusted both LoginViewModel and AccountTypeSelectorViewModel to work with it, along with that AccountTypeSelectorViewModel now properly logs the user.
      
      Extended OIDAuthState to parse JWTokens.
      
      TODO: 
      Make VM/VC more cohesive between both with marks, etc...
      Troubleshot bugs.
      Pass tests and update them with the new login logic.
      Move and re-name new classes to their proper places in the internal structure and logic of the project.
      Cleanup the new classes.
      PEMA-309 Fixed bug
      
      UI was set to be permanently loading, it isn't anymore.
      5110ab11
    • Sascha Bacardit's avatar
      PEMA-309 Altered log in logic · e7a428d4
      Sascha Bacardit authored
      The process to log in via OAuth2 is now seamless, when the OAuth logging button is pressed and post segue to the login screen, the OAuth2 process will be automatically launched and all the important user data will be set directly from the OAuth request.
      
      TODO: Properly review if moving all the login in logic to a helper would make it cleaner (as to avoid repeating this logic in both the login VM and account type select VM.
      TODO: Move the JWT logic to it's own class or library to mirror android and avoid dependency bloat.
      e7a428d4
    • Sascha Bacardit's avatar
      PEMA-309 Fixed bug with Office365 OAuth2 · 871f0725
      Sascha Bacardit authored
      Office 365 demands to add OpenID scope, google does not
      871f0725
    • Sascha Bacardit's avatar
      PEMA-309 Added JWT handling for display name · 6129fa57
      Sascha Bacardit authored
      Acquiring the display name is possible via adding the proper scope (profile), which means that the UI should seamlessly log into oath accounts.
      
      Note that the JWT might be updated or changed, as such to cope with that the token fields should be gotten on call instead of being static.
      6129fa57
    • Sascha Bacardit's avatar
      PEMA-309 OAuth automatically sets up user email · a4b633a6
      Sascha Bacardit authored
      Made OAuth2 automatically set up the email, this is done via adding the scope OpenID and Email so the idToken outputs a parseable JWT which contains the field email.
      
      TODO: Clean up code, remove email field (leave only user field) in case profile does not output username.
      a4b633a6
    • Martin's avatar
      PEMA-312 - add client certificate button · cfe9e1be
      Martin authored
      cfe9e1be
    • Martin's avatar
      PEMA-312 - switch must be exhaustive · afa00779
      Martin authored
      afa00779
    • Martin's avatar
      PEMA-312 - clean up code · 48d16373
      Martin authored
      48d16373
    • Martin's avatar
      PEMA-312 - remove perform segue · 70d7e3f4
      Martin authored
      70d7e3f4
    • Martin's avatar
      PEMA-312 - basic navigation · 1631dce4
      Martin authored
      1631dce4
    • Sascha Bacardit's avatar
      PEMA-309 Fixed bug with Office365 OAuth2 · ea617094
      Sascha Bacardit authored
      Office 365 demands to add OpenID scope, google does not
      ea617094
    • Sascha Bacardit's avatar
      PEMA-309 Added JWT handling for display name · 686fc06d
      Sascha Bacardit authored
      Acquiring the display name is possible via adding the proper scope (profile), which means that the UI should seamlessly log into oath accounts.
      
      Note that the JWT might be updated or changed, as such to cope with that the token fields should be gotten on call instead of being static.
      686fc06d
    • Martin's avatar
      PEMA-312 - add vc to sb · 822ebf34
      Martin authored
      822ebf34
    • Martin's avatar
      PEMA-312 - replace assets · 93c41ad6
      Martin authored
      93c41ad6
    • Sascha Bacardit's avatar
      PEMA-309 OAuth automatically sets up user email · 2b424f66
      Sascha Bacardit authored
      Made OAuth2 automatically set up the email, this is done via adding the scope OpenID and Email so the idToken outputs a parseable JWT which contains the field email.
      
      TODO: Clean up code, remove email field (leave only user field) in case profile does not output username.
      2b424f66
    • Dirk Zimmermann's avatar
      Enable echo protocol when not under MDM · 4994484b
      Dirk Zimmermann authored
      4994484b
  3. Mar 14, 2023
  4. Mar 09, 2023
    • Sascha Bacardit's avatar
      PEMA-309 further refined code · bb79f32a
      Sascha Bacardit authored
      After reading the code review the following changes have been added:
      -Made isCloud less exposing to inner data.
      -Added descriptor for LoginProtocol
      -Added guard let to most functions in LoginUtil and those using callbacks from it.
      bb79f32a
    • Martin Brude's avatar
      PEMA-222 - stop supporting landscape · 43187da9
      Martin Brude authored
      43187da9
    • Martin Brude's avatar
      PEMA-222 - disable orientations · 73aa9708
      Martin Brude authored
      73aa9708
    • Sascha Bacardit's avatar
      PEMA-309 removed class · 996784cd
      Sascha Bacardit authored
      OIDAuthState should not exist (moved to messagemodel)
      996784cd
    • Sascha Bacardit's avatar
      PEMA-309 refractored classes · d558f418
      Sascha Bacardit authored
      After review, most classes had small issues with their formating or location, as such the following has been fixed:
      Added proper tab and formating for them
      Renamed certain classes to keep within expected logic (CamelCase, OIDAuthState+JWT)
      Moved OIDauthState to messagemodel along with most OAuth adjacent classes where it should be.
      Changed OIDAuth signature to remove references to things the class shouldn't know (such as the name of fields inside the JWToken) 
      Refractored OAuth2AccessToken and protocol to fit with being able to give email and name from the JWToken.
      d558f418
    • Martin Brude's avatar
      PEMA-161 - fix ui bug · fd213adf
      Martin Brude authored
      fd213adf
  5. Mar 08, 2023
  6. Mar 07, 2023
  7. Mar 06, 2023
    • Sascha Bacardit's avatar
      PEMA-309 · ec5d5fed
      Sascha Bacardit authored
      Further cleaned up the classes, added less strange ways to set up things and removed oddities like an initialise function which didn't make much sense, as the protocol doesn't really care how you handle your responses.
      ec5d5fed
    • Sascha Bacardit's avatar
      PEMA-309 · fd32a697
      Sascha Bacardit authored
      Cleaned up code, removed old dead code and added placeholder tests.
      Additionally added comments to the stranger functions (OIDauth extension).
      fd32a697