- Mar 16, 2023
-
-
Sascha Bacardit authored
-
Sascha Bacardit authored
-
Dirk Zimmermann authored
-
- Mar 15, 2023
-
-
Sascha Bacardit authored
Added guard let construct Properly intended messages Fixed incoherent messages (sometimes no email provider name, sometimes it had it on ouath)
-
Sascha Bacardit authored
After reading the code review the following changes have been added: -Made isCloud less exposing to inner data. -Added descriptor for LoginProtocol -Added guard let to most functions in LoginUtil and those using callbacks from it.
-
Sascha Bacardit authored
OIDAuthState should not exist (moved to messagemodel)
-
Sascha Bacardit authored
After review, most classes had small issues with their formating or location, as such the following has been fixed: Added proper tab and formating for them Renamed certain classes to keep within expected logic (CamelCase, OIDAuthState+JWT) Moved OIDauthState to messagemodel along with most OAuth adjacent classes where it should be. Changed OIDAuth signature to remove references to things the class shouldn't know (such as the name of fields inside the JWToken) Refractored OAuth2AccessToken and protocol to fit with being able to give email and name from the JWToken.
-
Sascha Bacardit authored
Further cleaned up the classes, added less strange ways to set up things and removed oddities like an initialise function which didn't make much sense, as the protocol doesn't really care how you handle your responses.
-
Sascha Bacardit authored
Cleaned up code, removed old dead code and added placeholder tests. Additionally added comments to the stranger functions (OIDauth extension).
-
Sascha Bacardit authored
Added temporary test placeholders.
-
Sascha Bacardit authored
Added abstraction class for login, it should handle all cases and all internal login logic (saving data, etc...) only returning an error state or a success state. Adjusted both LoginViewModel and AccountTypeSelectorViewModel to work with it, along with that AccountTypeSelectorViewModel now properly logs the user. Extended OIDAuthState to parse JWTokens. TODO: Make VM/VC more cohesive between both with marks, etc... Troubleshot bugs. Pass tests and update them with the new login logic. Move and re-name new classes to their proper places in the internal structure and logic of the project. Cleanup the new classes. PEMA-309 Fixed bug UI was set to be permanently loading, it isn't anymore.
-
Sascha Bacardit authored
The process to log in via OAuth2 is now seamless, when the OAuth logging button is pressed and post segue to the login screen, the OAuth2 process will be automatically launched and all the important user data will be set directly from the OAuth request. TODO: Properly review if moving all the login in logic to a helper would make it cleaner (as to avoid repeating this logic in both the login VM and account type select VM. TODO: Move the JWT logic to it's own class or library to mirror android and avoid dependency bloat.
-
Sascha Bacardit authored
Office 365 demands to add OpenID scope, google does not
-
Sascha Bacardit authored
Acquiring the display name is possible via adding the proper scope (profile), which means that the UI should seamlessly log into oath accounts. Note that the JWT might be updated or changed, as such to cope with that the token fields should be gotten on call instead of being static.
-
Sascha Bacardit authored
Made OAuth2 automatically set up the email, this is done via adding the scope OpenID and Email so the idToken outputs a parseable JWT which contains the field email. TODO: Clean up code, remove email field (leave only user field) in case profile does not output username.
-
Martin authored
-
Martin authored
-
Martin authored
-
Martin authored
-
Martin authored
-
Sascha Bacardit authored
Office 365 demands to add OpenID scope, google does not
-
Sascha Bacardit authored
Acquiring the display name is possible via adding the proper scope (profile), which means that the UI should seamlessly log into oath accounts. Note that the JWT might be updated or changed, as such to cope with that the token fields should be gotten on call instead of being static.
-
Martin authored
-
Martin authored
-
Sascha Bacardit authored
Made OAuth2 automatically set up the email, this is done via adding the scope OpenID and Email so the idToken outputs a parseable JWT which contains the field email. TODO: Clean up code, remove email field (leave only user field) in case profile does not output username.
-
Dirk Zimmermann authored
-
- Mar 14, 2023
-
-
Sascha Bacardit authored
Added guard let construct Properly intended messages Fixed incoherent messages (sometimes no email provider name, sometimes it had it on ouath)
-
- Mar 09, 2023
-
-
Sascha Bacardit authored
After reading the code review the following changes have been added: -Made isCloud less exposing to inner data. -Added descriptor for LoginProtocol -Added guard let to most functions in LoginUtil and those using callbacks from it.
-
Martin Brude authored
-
Martin Brude authored
-
Sascha Bacardit authored
OIDAuthState should not exist (moved to messagemodel)
-
Sascha Bacardit authored
After review, most classes had small issues with their formating or location, as such the following has been fixed: Added proper tab and formating for them Renamed certain classes to keep within expected logic (CamelCase, OIDAuthState+JWT) Moved OIDauthState to messagemodel along with most OAuth adjacent classes where it should be. Changed OIDAuth signature to remove references to things the class shouldn't know (such as the name of fields inside the JWToken) Refractored OAuth2AccessToken and protocol to fit with being able to give email and name from the JWToken.
-
Martin Brude authored
-
- Mar 08, 2023
-
-
Martin Brude authored
-
Martin Brude authored
-
Tabaré Sascha Bacardit Cuomo authored
PEMA-380 Made the UI account for the extra buttons. See merge request iOS/pep4ios!72
-
- Mar 07, 2023
-
-
Sascha Bacardit authored
UI didn't account for the extra buttons, it has been fixed now.
-
Dirk Zimmermann authored
-
- Mar 06, 2023
-
-
Sascha Bacardit authored
Further cleaned up the classes, added less strange ways to set up things and removed oddities like an initialise function which didn't make much sense, as the protocol doesn't really care how you handle your responses.
-
Sascha Bacardit authored
Cleaned up code, removed old dead code and added placeholder tests. Additionally added comments to the stranger functions (OIDauth extension).
-